New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support to parameters referenceLiquibaseCatalogName and referenceLiquibaseSchemaName. #4352
Adding support to parameters referenceLiquibaseCatalogName and referenceLiquibaseSchemaName. #4352
Conversation
ca72557
to
b701808
Compare
Hello @TymofiiKritsak - I implemented the requested changes and did some manual test to confirm that they are working. Do you plan to create any integration tests for them? |
...se-integration-tests/src/test/resources/liquibase/extension/testing/command/diff.test.groovy
Show resolved
Hide resolved
can we add unit tests here? I mean these parameters just build connection string, right? so maybe it's enough just unit tests? |
PD ticket created: https://datical.atlassian.net/browse/PD-3557 |
Hi @filipelautert! |
@filipelautert also agreed to add an integration h2 test for this one |
@MalloD12 are you able to add the tests as discussed here? |
integration tests added, test-only ticket for fucntional tests created, all tests passed |
…nceLiquibaseSchemaName.
ab8540e
to
b0b32cd
Compare
Might have worked at some point but apparently some overzealous commandline validator doesn't think so |
Impact
Description
Adding support to parameters referenceLiquibaseCatalogName and referenceLiquibaseSchemaName.
Instead of adding a global parameter as referenceCatalogName and referenceSchemaName, it was added as a parameter only to the commands that would use it, namely: Diff, diffChangelog and SnapshotReference .