Make CreateTableStatement backward compatible #4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for backward compatibility. Amend liquibase#3108.
MalloD12
added
the
SafeToBuild
MalloD12
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Approved.
Changes looks good to me. Thank you @jccampanero for creating this PR to amend #3108.
No need to add additional test cases, since there are already unit and integration tests which will make use of the different constructors. Build and all tests checks have been successfully executed.
Sorry again for the late reply @MalloD12 Daniel. You are welcome, my pleasure. |
filipelautert
approved these changes
Jun 28, 2023
jccampanero
deleted the
4322_backward_incompatibility_createtablestatement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Add a four argument constructor to
CreateTableStatementto make it backward compatible.Fixes #4322.
Amend #3108.
Things to be aware of
Nothing.
Things to worry about
Nothing.
Additional Context
N/A.