Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more parameter markers for DB2z catalogue queries #4387

Merged
merged 14 commits into from Aug 23, 2023
Merged

Use more parameter markers for DB2z catalogue queries #4387

merged 14 commits into from Aug 23, 2023

Conversation

MichaelKern-IVV
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Use parameter markers for DB2z catalogue queries to improve performance.

Fixes #3791 (second half)

@filipelautert
Copy link
Collaborator

@kevin-atx this PR is a second part of DB2z improvements that @MichaelKern-IVV is providing - first part just got merged. If possible can we review it and prioritize soon? @tati-qalified FYI

@filipelautert filipelautert self-assigned this Jul 4, 2023
@filipelautert filipelautert added sprint2023-54 SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Jul 4, 2023
@filipelautert filipelautert added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Jul 4, 2023
filipelautert
filipelautert approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR replaces some usages of String by RawSqlStatement thus enabling the use of RawParameterizedSqlStatement by DB2 queries.

@filipelautert filipelautert merged commit 9cc6c8e into liquibase:master Aug 23, 2023
14 of 15 checks passed
@filipelautert filipelautert added this to the 1NEXT milestone Aug 23, 2023
@MichaelKern-IVV MichaelKern-IVV deleted the paramBinding branch September 29, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipelautert filipelautert filipelautert approved these changes

@rberezen rberezen rberezen approved these changes

@suryaaki2 suryaaki2 Awaiting requested review from suryaaki2

Assignees

@filipelautert filipelautert

Labels
DBDB2Z SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions sprint2023-54 TypeEnhancement
Projects
Liquibase Open Source
Archived in project
Milestone
v4.24.0
Development

Successfully merging this pull request may close these issues.

Use parameter markers for catalogue queries
5 participants
@MichaelKern-IVV @filipelautert @rberezen @kevin-atx @michaelmatthiaskern