Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAT-15030 #4409

Merged
merged 9 commits into from Jun 26, 2023
Merged

DAT-15030 #4409

merged 9 commits into from Jun 26, 2023

Conversation

sayaliM0412
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Enforce labels on every PR. Cannot merge until a label is added to the PR.

@sayaliM0412 sayaliM0412 added the skipReleaseNotes skip the Draft Release Notes label Jun 20, 2023
@sayaliM0412 sayaliM0412 self-assigned this Jun 20, 2023
@sayaliM0412 sayaliM0412 marked this pull request as ready for review June 20, 2023 21:08
abrackx
abrackx requested changes Jun 21, 2023
View reviewed changes
.github/pull_request_template.md Outdated Show resolved Hide resolved
@sayaliM0412 sayaliM0412 marked this pull request as draft June 21, 2023 13:29
@sayaliM0412 sayaliM0412 marked this pull request as ready for review June 21, 2023 18:57
@sayaliM0412
Copy link
Contributor Author

I will merge this PR after the merge freeze is lifted

@sayaliM0412 sayaliM0412 added TypeEnhancement and removed skipReleaseNotes skip the Draft Release Notes labels Jun 26, 2023
abrackx
abrackx approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@abrackx abrackx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Awesome!

@sayaliM0412 sayaliM0412 merged commit 3bf82ba into master Jun 26, 2023
16 checks passed
@sayaliM0412 sayaliM0412 deleted the enforce_labels_DAT-15030 branch June 26, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrackx abrackx abrackx approved these changes

@filipelautert filipelautert Awaiting requested review from filipelautert filipelautert is a code owner

Assignees

@sayaliM0412 sayaliM0412

Labels
TypeEnhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sayaliM0412 @filipelautert @abrackx