Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #4413: Undocumented IT requirement: Username "liquibase" #4414

Merged
merged 1 commit into from Jun 29, 2023
Merged

Fixes issue #4413: Undocumented IT requirement: Username "liquibase" #4414

merged 1 commit into from Jun 29, 2023

Conversation

mkarg
Copy link
Contributor

@mkarg mkarg commented Jun 21, 2023

Fixes #4413

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Despite the title and description of issue #4413, the actual cause of the failing IT was not an undocumented IT requirement, but the fact that the author of the IT (unintentionally) used the static prefix "liquibase" instead of the dynamic prefix provided by the test driver.

The solution hence is to replace the static prefix by the dynamic prefix. Hence, there is nothing wrong with the test documentation.

Things to be aware of

N/A

Things to worry about

N/A

Additional Context

N/A

@mkarg
Copy link
Contributor Author

mkarg commented Jun 21, 2023

@filipelautert Kindly requesting you review. Thanks! :-)

@mkarg
Fixes issue liquibase#4413: Undocumented IT requirement: Username "li…
a8e7b89 
…quibase"

Despite the title and description of issue liquibase#4413, the actual cause of
the failing IT was *not* an undocumented IT requirement, but the fact
that the author of the IT (unintentionally) used the static prefix
"liquibase" instead of the dynamic prefix provided by the test driver.

The solution hence is to replace the static prefix by the dynamic
prefix. Hence, there is nothing wrong with the test documentation.
@filipelautert filipelautert added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions sprint2023-54 TypeBug labels Jun 21, 2023
@filipelautert filipelautert self-assigned this Jun 22, 2023
filipelautert
filipelautert approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes a hardcoded value found in tests.

@filipelautert filipelautert merged commit 75ac1c1 into liquibase:master Jun 29, 2023
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipelautert filipelautert filipelautert approved these changes

@rberezen rberezen rberezen approved these changes

@suryaaki2 suryaaki2 Awaiting requested review from suryaaki2

Assignees

@filipelautert filipelautert

Labels
SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions sprint2023-54 TypeBug
Projects
Liquibase Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undocumented IT requirement: Username "liquibase"
3 participants
@mkarg @filipelautert @rberezen