Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix primaryKeyTablespace when attribute value is an empty string #4441

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Fix primaryKeyTablespace when attribute value is an empty string #4441

merged 7 commits into from
Aug 29, 2023

Conversation

delayk
Copy link
Contributor

@delayk delayk commented Jun 27, 2023 •
edited by MalloD12

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

TypeBug - bug fixes

Description

Add StringUtil.trimToNull() before checking the tablespace value of the primary key constraint, to avoid appending USING INDEX TABLESPACE when primaryKeyTablespace attribute is an empty string.

Fixes #3630

Things to be aware of

Things to worry about

Additional Context

@delayk
Fix issue liquibase#3630
5f8556a 
Add StringUtil.trimToNull() before checking the tablespace value of the primary key constraint.
@delayk
Copy link
Contributor Author

delayk commented Jun 30, 2023

@filipelautert please review.

@filipelautert filipelautert added the SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions label Jun 30, 2023
@MalloD12 MalloD12 self-assigned this Jul 6, 2023
@MalloD12 MalloD12 self-requested a review July 6, 2023 15:06
@MalloD12 MalloD12 changed the base branch from master to 3.3.x July 6, 2023 16:28
@MalloD12 MalloD12 changed the base branch from 3.3.x to master July 6, 2023 16:28
@MalloD12 MalloD12 added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Jul 6, 2023
@MalloD12 MalloD12 changed the title Fixes #3630 Fix primaryKeyTablespace when attribute value is an empty string Jul 6, 2023
@MalloD12 MalloD12 removed the SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions label Jul 6, 2023
@MalloD12 MalloD12 added the SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions label Jul 6, 2023
@MalloD12 MalloD12 removed the SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions label Jul 17, 2023
@MalloD12 MalloD12 added the SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions label Jul 17, 2023
MalloD12
MalloD12 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Review and testing results:

Thanks @delayk for submitting this PR. It looks ok to me, I manually double check it and seems to be working fine for me.

Build and all test checks have been successfully executed.

Things to be aware of:

  • None

Things to worry about:

  • None

@MalloD12 MalloD12 requested a review from rberezen July 20, 2023 15:49
@rberezen rberezen added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Jul 25, 2023
@rberezen rberezen added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Jul 25, 2023
@filipelautert filipelautert merged commit 5e30bb5 into liquibase:master Aug 29, 2023
56 of 57 checks passed
@filipelautert filipelautert added this to the 1NEXT milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipelautert filipelautert filipelautert approved these changes

@rberezen rberezen rberezen approved these changes

@MalloD12 MalloD12 MalloD12 approved these changes

@suryaaki2 suryaaki2 suryaaki2 approved these changes

Assignees

@MalloD12 MalloD12

Labels
SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions sprint2023-55 TypeBug
Projects
Liquibase Open Source
Archived in project
Milestone
v4.24.0
6 participants
@delayk @filipelautert @rberezen @MalloD12 @suryaaki2 @kevin-atx