Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #4489: SQL Anywhere incorrectly reports VARCHAR(n CHAR) as VARCHAR(n) #4499

Merged
merged 3 commits into from Jul 28, 2023
Merged

Fixed #4489: SQL Anywhere incorrectly reports VARCHAR(n CHAR) as VARCHAR(n) #4499

merged 3 commits into from Jul 28, 2023

Conversation

mkarg
Copy link
Contributor

@mkarg mkarg commented Jul 15, 2023 •
edited

Description

Fixes #4489

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Cause: There is no way to detect the size unit in the JDBC standard.

Solution: Using a native query to detect the size unit.

Things to be aware of

N/A

Things to worry about

N/A

Additional Context

N/A

@mkarg
Fixed liquibase#4489: SQL Anywhere incorrectly reports VARCHAR(n CHAR…
28f31bd 
…) as VARCHAR(n)

Cause: There is no way to detect the size unit in the JDBC standard.

Solution: Using a native query to detect the size unit.
@mkarg mkarg marked this pull request as ready for review July 15, 2023 14:40
@mkarg
Copy link
Contributor Author

mkarg commented Jul 15, 2023

@nvoxland Kindly requesting your review. :-)

@mkarg mkarg mentioned this pull request Jul 19, 2023
Merged
3 tasks
@filipelautert filipelautert self-assigned this Jul 20, 2023
@filipelautert filipelautert added the SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions label Jul 20, 2023
filipelautert
filipelautert approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, new native sql for sql anywhere. Thanks!

@mkarg
Copy link
Contributor Author

mkarg commented Jul 24, 2023

This is a showstopper at least for SQL Anywhere.

@rberezen rberezen added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Jul 25, 2023
@rberezen rberezen added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Jul 25, 2023
@rberezen
Copy link
Contributor

This pull request addresses the issue in Liquibase where the detection of CHAR(n CHAR) and VARCHAR(n CHAR) fields as byte-sized instead of char-sized caused problems in SQL Anywhere.

  • Functional and test harness executions passing.
  • No additional testing required.

APPROVED

@filipelautert filipelautert merged commit 24324e2 into liquibase:master Jul 28, 2023
32 of 37 checks passed
@filipelautert filipelautert added this to the 1NEXT milestone Jul 28, 2023
@mkarg mkarg deleted the n-chars branch July 29, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvoxland nvoxland nvoxland approved these changes

@filipelautert filipelautert filipelautert approved these changes

@rberezen rberezen rberezen approved these changes

@suryaaki2 suryaaki2 suryaaki2 approved these changes

Assignees

@filipelautert filipelautert

Labels
DBSQLAnywhere SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions TypeBug
Projects
Liquibase Open Source
Archived in project
Milestone
v4.23.1
Development

Successfully merging this pull request may close these issues.

SQL Anywhere incorrectly reports VARCHAR(n CHAR) as VARCHAR(n)
6 participants
@mkarg @rberezen @nvoxland @filipelautert @suryaaki2 @kevin-atx