Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Anywhere: Not trimming anything, as SQL Anywhere does not need it but supports distinction-by-blank #4535

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mkarg
Copy link
Contributor

@mkarg mkarg commented Jul 25, 2023

Closes #4521

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

SQL Anywhere does never blank-pad any information provided to Liquibase, so there is no need for trimming.

SQL Anywhere does support duplicate names that differ only by blank padding. For example, one can have all the tables or columns X, X , X and X, and SQL Anywhere correctly can tell which one you want as long as they are correctly double-quoted.

Things to be aware of

N/A

Things to worry about

N/A

Additional Context

N/A

@mkarg
Copy link
Contributor Author

mkarg commented Jul 25, 2023

This PR is in draft mode, because the current solution is not complete. While we do not trim, and while the retrieval of the information from the database correctly results in distinct X, X , X and X instances of CachedRow, the outcome for generateChangelog still is one single consolidated object X. After two days of trying to understand why (and where) this happens, I am running out of time. If someone could chime in and tell me the why and where, I would be happy to finish this PR. Until then, unfortunately I need to invest my time in lower hanging fruits. 😓

@filipelautert
Copy link
Collaborator

@mkarg does this PR still a work in progress?

@mkarg
Copy link
Contributor Author

mkarg commented Sep 21, 2023

@filipelautert I am currently busy with other projects, so this PR is suspended until at least end of October. I hope to find the time to continue work then.

@filipelautert
Copy link
Collaborator

Thanks for the update @mkarg ! We can wait, no problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Discussion
Development

Successfully merging this pull request may close these issues.

SQL Anywhere allows object identifiers containing blanks
3 participants