Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAT-15208 :: Changeset object added back to "Update command completed successfully" JSON #4556

Closed
wants to merge 2 commits into from

Conversation

MalloD12
Copy link
Contributor

Update logDeploymentOutcomeMdc to add mdc values before logging update command execution result"

{
  "timestamp": "2023-07-27T19:58:58.897Z",
  "level": "INFO",
  "class": "liquibase.command",
  "thread": "1",
  "message": "Update command completed successfully.",
  "operationStart": "2023-07-27T16:58:58.367",
  "liquibaseCommandName": "update",
  "liquibaseInternalCommand": "update",
  "liquibaseTargetUrl": "jdbc:postgresql://localhost:5438/lbcat",
  "liquibaseCatalogName": "lbcat",
  "liquibaseSchemaName": "",
  "rollbackOnError": "true",
  "commandLabelFilter": "primaryTable",
  "commandContextFilter": "fltr1",
  "deploymentId": "0487938863",
  "changelogFile": "changelogWithDropTableNotExistChangeset.xml",
  "rowsAffected": "1",
  "deploymentOutcomeCount": "1",
  "changesetsUpdated": {
    "changeset": [
      {
        "changesetAuthor": "Liquibase Pro User",
        "changesetFilepath": "changelogWithDropTableNotExistChangeset.xml",
        "changesetId": "createPrimaryTable",
        "changesetOutcome": "EXECUTED",
        "deploymentId": "0487938863"
      }
    ]
    ,
    "changesetCount": 1
  },
  "deploymentOutcome": "success"
}

Impact

  • [ x] Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

  • None

Things to worry about

  • None

Additional Context

  • Nothing

@MalloD12
Copy link
Contributor Author

Hi guys, I just would like to check with you whether you think we should unit test this. I talked to Oleksii and confirmed to me we are covering this case as part of the functional tests in the UpdateCountStructuredLoggingTests and UpdateWithStructuredLoggingTests test suites.

@wwillard7800
Copy link
Contributor

There are also tests in the liqubase-pro repository that should cover this. They run with each build.

@MalloD12
Copy link
Contributor Author

Guys, closing this one and opening #4581 in order to avoid issues with the branch name. Regarding the test I saw failing it was because of an environment variable value I was using.

@MalloD12 MalloD12 closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants