Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dat 15548/feature/devops #4594

Closed
wants to merge 8 commits into from
Closed

Dat 15548/feature/devops #4594

wants to merge 8 commits into from

Conversation

jandroav
Copy link
Contributor

@jandroav jandroav commented Aug 3, 2023

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

…hFileName to improve clarity and semantics

feat(build.yml): add support for packaging and deploying artifacts with branch name in the file name for convenience and clarity
…` to use the correct branch name in the Maven command
…s to handle special characters in the branch name

fix(build-main.yml): fix the value of build.branch to use thisBranchFileName instead of thisBranchName to match the correct variable value
… slashes with dashes

The version artifact naming in the build-branch.yml workflow is updated to replace forward slashes with dashes. This is done to ensure that the artifact name is compatible with the naming conventions used in the project.
…ing and deployment

fix(build.yml): fix version string by replacing forward slashes with dashes to avoid issues with file naming conventions
…ch name to improve versioning semantics

chore(build.yml): replace forward slashes with hyphens in version to improve versioning semantics
…ignment to prevent literal string assignment

fix(build.yml): remove unnecessary sed command to replace / with - in version variable assignment
…d maintainability

feat(build.yml): add step to version artifact based on branch name to improve traceability and identification of artifacts
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Label error: This PR is being prevented from merging because you have not added one of the labels: APIBreakingChanges, breakingChanges, newContributors, notableChanges, sdou, skipReleaseNotes, TypeBug, TypeEnhancement, TypeTest. You'll need to add it before this PR can be merged.

@jandroav jandroav closed this Aug 4, 2023
@jandroav jandroav deleted the DAT-15548/feature/devops branch August 4, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant