-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sequence from serial pre-condition validation for Postgresql #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l type are computed as autoincrement instead of normal sequence by SequenceSnapshotGenerator
filipelautert
force-pushed
the
fix-issue-1163
branch
from
August 7, 2023 22:06
a2b294c
to
770a2f0
Compare
filipelautert
changed the title
Create a specific query for Postgresql, as sequences created by seria…
Create a specific query for Postgresql, as sequences created by serial type are computed as autoincrement instead of normal sequence by SequenceSnapshotGenerator
Aug 7, 2023
filipelautert
changed the title
Create a specific query for Postgresql, as sequences created by serial type are computed as autoincrement instead of normal sequence by SequenceSnapshotGenerator
Fix sequence from serial validation for Postgresql
Aug 7, 2023
filipelautert
changed the title
Fix sequence from serial validation for Postgresql
Fix sequence from serial pre-condition validation for Postgresql
Aug 7, 2023
MalloD12
reviewed
Aug 8, 2023
liquibase-standard/src/main/java/liquibase/precondition/core/SequenceExistsPrecondition.java
Outdated
Show resolved
Hide resolved
I think it would be nice to add a changeset like this one:
To our |
MalloD12
approved these changes
Aug 8, 2023
rberezen
approved these changes
Aug 28, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a specific query for Postgresql, as sequences created by serial type are computed as autoincrement instead of normal sequence by SequenceSnapshotGenerator
Impact
Description
Create a specific query for Postgresql to be used by pre conditions as sequences created by serial type are computed as autoincrement instead of normal sequence by SequenceSnapshotGenerator
Additional Context
Fixes #1163