Fixed: Issue #4620 - "SQL Anywhere DOES support CREATE OR REPLACE VIEW, despite what the source code says!" #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…W, despite what the source code says!
MalloD12
added
the
SafeToBuild
MalloD12
added
SafeToBuild
MalloD12
added
the
SafeToBuild
MalloD12
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
This looks good to me. Made a minor update on one of the test assertions related to this change.
There are still some build errors (not related with this PR) and functional and test harness test suites cannot be executed, but I double checked on both DB supported matrix and there is not SQL Anywhere execution we need to worry about.
filipelautert
approved these changes
Aug 29, 2023
suryaaki2
approved these changes
Sep 5, 2023
rberezen
approved these changes
Sep 7, 2023
filipelautert
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Fixes #4620
As SQL Anywhere supports OR REPLACE since more than a decade, we can safely remove all the special treatment for
replaceIfExists=truein the source code. I used it for several hours with that change and it just works fine out-of-the-box in all cases, withfullDefinition=true/false, etc. Apparently this code was just a leftover from the very ancient days and is not needed since at least 10 years.https://help.sap.com/docs/SAP_SQL_Anywhere/93079d4ba8e44920ae63ffb4def91f5b/816d37a36ce21014bf6cacd0588a42f3.html
Things to be aware of
Very, very, very outdated versions of SQL Anywhere actually did not support OR REPLACE.
Things to worry about
Do not use SQL Anywhere unsupported releases, i. e. v17.x, available since approx. a decade.
Additional Context
N/A