Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DatabaseChangelog object to be passed as a parameter to DatabaseChangelogCommandStep #4653

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

filipelautert
Copy link
Collaborator

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Allow DatabaseChangelog object to be passed as a parameter to DatabaseChangelogCommandStep instead of just accepting changelog file as it used to be before command refactoring.

…eChangelogCommandStep instead of just accepting changelog file.
Copy link
Contributor

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good to me. I modify a test from UpdateCommandsIntegrationTest in order to execute an update command either with a changelog path or with a changelog object.

@filipelautert filipelautert added this to the 1NEXT milestone Aug 29, 2023
@filipelautert filipelautert merged commit ef1f9f5 into master Aug 29, 2023
29 checks passed
@filipelautert filipelautert deleted the 4491-commandvalidationexception branch August 29, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
4 participants