Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Regression in 4.23.1 where Log table is created multiple times for H2 and HSQLDB #4709

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Fix Regression in 4.23.1 where Log table is created multiple times for H2 and HSQLDB #4709

merged 2 commits into from
Aug 24, 2023

Conversation

filipelautert
Copy link
Collaborator

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Removes duplicate init as it has been already initialized on DatabaseChangeLogCommandStep

@filipelautert filipelautert self-assigned this Aug 21, 2023
@filipelautert filipelautert linked an issue Aug 21, 2023 that may be closed by this pull request
Regression in 4.23.1: Log table is created multiple times #4684
Closed
2 tasks
@filipelautert filipelautert marked this pull request as ready for review August 21, 2023 22:23
@filipelautert filipelautert force-pushed the 4684-regression-in-4231-log-table-is-created-multiple-times branch from c73d36e to 83c98fc Compare August 22, 2023 16:42
@filipelautert filipelautert changed the title Fix Regression in 4.23.1 where Log table is created multiple times for H2 Fix Regression in 4.23.1 where Log table is created multiple times for H2 and HSQLDB Aug 22, 2023
@filipelautert filipelautert force-pushed the 4684-regression-in-4231-log-table-is-created-multiple-times branch from 83c98fc to 6219885 Compare August 23, 2023 17:56
@filipelautert filipelautert force-pushed the 4684-regression-in-4231-log-table-is-created-multiple-times branch from 6219885 to 90109a1 Compare August 24, 2023 17:26
@filipelautert filipelautert added this to the 1NEXT milestone Aug 24, 2023
@filipelautert filipelautert merged commit 19b8710 into master Aug 24, 2023
28 of 29 checks passed
@filipelautert filipelautert deleted the 4684-regression-in-4231-log-table-is-created-multiple-times branch August 24, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwillard7800 wwillard7800 wwillard7800 approved these changes

@rberezen rberezen Awaiting requested review from rberezen

Assignees

@filipelautert filipelautert

Labels
TypeBug
Projects
Liquibase Open Source
Archived in project
Milestone
v4.24.0
Development

Successfully merging this pull request may close these issues.

Regression in 4.23.1: Log table is created multiple times
2 participants
@filipelautert @wwillard7800