Corrected determination of the DB2 version for the support of BOOLEAN columns. (patch for #4723) #4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-atx
changed the title
MalloD12
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Approved.
Review and testing results:
Thanks you, @haltenwe for this PR. Code changes looks good to me. With this version check changed on the supportBooleanDataType() we started getting some tests failures. Some of this required a separate PR to fix the failing test, and some others were fixed by the change made around the handleOldChangelogTableFormat().
Build and most of the tests checks have been successfully executed as shown in the below screenshot:
The failing check will pass again when this PR is merged.
Things to be aware of:
- None
Things to worry about:
- None
|
@filipelautert - @suryaaki2: once we merge this PR I'll ask Interop team to get their PR merged. Thanks, |
filipelautert
approved these changes
Sep 18, 2023
suryaaki2
approved these changes
Sep 20, 2023
Fix the error: check, that DB2Database is a superclass of the configured implementation Signed-off-by: Erich Haltenwanger <erich@haltenwanger.de>
Fixes liquibase#4723: check of the version of DB2 Signed-off-by: Erich Haltenwanger <erich@haltenwanger.de>
…ic when not using a LoggingExecutor.
filipelautert
force-pushed
the
haltenwe-patch-#4723
branch
from
a11d097
to
1329da1
Compare
rberezen
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
TypeBug
Description
Fixes #4723 Corrected determination of the DB2 version for the support of BOOLEAN columns. Fixed determining if the database implementation derives from DB2Database.
Things to be aware of
Things to worry about
Additional Context
IBM DB2 v11.1.1.1 and later