Fetch ran change sets before updating check sums

[hpoettker]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #4460.

The fix ensures that the field storedFilePath for each changeSet in UpdateChangeSetChecksumGenerator is set. Then, the WHERE condition of the produced UPDATE statements matches the database entry for the respective change set.

Things to be aware of

Things to worry about

Additional Context

[filipelautert]

@hpoettker interesting, this change is causing some tests to fail. I'm trying to figure out why.. any ideas?

[hpoettker]

@filipelautert Do you mean the integration tests for Oracle and MariaDB?

That is indeed curious. Both tests are failing when creating the sequence seqtestdatatypeonall with

• Oracle: CREATE SEQUENCE LBUSER.seqtestdatatypeonall AS int
• MariaDB: CREATE SEQUENCE lbcat.seqtestdatatypeonall AS int

I'd say that the AS int might work on PostgreSQL but is indeed invalid syntax for Oracle or MariaDB.

I don't see how my proposed change could cause such a problem. I also don't see how I can easily reproduce the test setup for the integration tests.

[hpoettker]

I found the yaml to get the integration tests working locally. 😄

The original PR was indeed erroneous. Using the constructor of ChangeLogIterator that takes the list of ran change sets seemed like an elegant idea at first sight. But it really does something much more specific than setting the stored file path in change sets.

I've also amended UpgradeChecksumVersionIntegrationTest with a test to reproduce the issue that this PR addresses.

[filipelautert]

Nice, good idea to fix it on ValidatingVisitor. In fact the Visitor is becoming a "fix it all" Visitor - something to think about .

@rberezen functional tests are passing here -> https://github.com/liquibase/liquibase-pro-tests/actions/runs/6038104842