DAT-15775 #4780

sayaliM0412 · 2023-08-29T16:57:29Z

Impact

Bug fix (non-breaking change which fixes expected existing functionality)
Enhancement/New feature (adds functionality without impacting existing logic)
Breaking change (fix or feature that would cause existing functionality to change)

build.yml: removing the use of workflow-helper.js from build.yml
run-tests.yml : consist of unit-tests and integration-tests. If the PR is from a forked repo, only authorize will allow the workflow to run.
new build.yml : build and publishes packages to build artifact page and GPM
functional-tests and tests-harness : are run after the new build.yml completes successfully. The link is visible on the run of run-tests.yml

Description

Things to be aware of

Things to worry about

Additional Context

This reverts commit c75d518.

…compareGeneratedSqlWithExpectedSqlForMinimalChangesets/alterSequence/mariadb.sql Signed-off-by: filipe <flautert@liquibase.org>

…compareGeneratedSqlWithExpectedSqlForMinimalChangesets/createSequence/mariadb.sql Signed-off-by: filipe <flautert@liquibase.org>

…compareGeneratedSqlWithExpectedSqlForMinimalChangesets/dropSequence/mariadb.sql Signed-off-by: filipe <flautert@liquibase.org>

…compareGeneratedSqlWithExpectedSqlForMinimalChangesets/renameSequence/mariadb.sql Signed-off-by: filipe <flautert@liquibase.org>

…t from

.github/workflows/build.yml

StevenMassaro · 2023-12-11T23:04:25Z

.github/workflows/build-branch.yml

+          latest_merge_sha=`(git rev-parse HEAD)`
+          echo "latestMergeSha=${latest_merge_sha}" >> $GITHUB_OUTPUT


I wonder if this will get us the sha we are looking for. We've had trouble using this kind of thing in the past, where it gave us commits that didn't exist, but that may have been so long ago that it's not a problem any more, particularly if we used to build with pull_request_target and now we don't (or vice versa). It's something to keep an eye on.

StevenMassaro · 2023-12-12T13:35:12Z

.github/workflows/build.yml

-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
-  cancel-in-progress: true
+  group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}
+  cancel-in-progress: false


Is cancel-in-progress supposed to be false?

I will check on this again. I remember I had to do this for testing.

StevenMassaro · 2023-12-12T13:36:48Z

.github/workflows/build.yml

          ## verify that the contents of the tar matches the expectation
-          echo "Comparing the contents of the tar.gz with the expected contents (using baseline file in liquibase-dist directory) to ensure that no new files were accidentally added. A failure here indicates that a new file was added to the tar.gz, and it should either be rectififed or added to the baseline."
+          #echo "Comparing the contents of the tar.gz with the expected contents (using baseline file in liquibase-dist directory) to ensure that no new files were accidentally added. A failure here indicates that a new file was added to the tar.gz, and it should either be rectififed or added to the baseline."


Suggest you uncomment this echo

StevenMassaro · 2023-12-12T13:37:44Z

.github/workflows/build.yml

-            }
+  run-functional-tests:
+    needs: [ setup, build_publish_branch ]
+    uses: liquibase/liquibase/.github/workflows/run-functional-tests.yml@github-action-DAT-15775


Should this line have @github-action-DAT-15775 in it?

this was taken care of

StevenMassaro · 2023-12-12T13:38:13Z

.github/workflows/create-release.yml

Should the steps in this workflow be commented out?

The azure uber jar was creating issue during last release as well. I did not want to look into it for this ticket and go down that rabbit hole.

StevenMassaro · 2023-12-12T13:39:08Z

.github/workflows/run-functional-tests.yml

+      - name: Report PRO-Tests Run URL
+        uses: actions/github-script@v6.4.1
+        with:
+          script: |
+            const targetURL = "https://github.com/liquibase/liquibase-pro-tests/actions/runs/${{ steps.return_dispatch.outputs.run_id }}"
+            core.notice("Pro-Tests Run URL: " + targetURL);


This is a great addition, nice job!

StevenMassaro · 2023-12-12T13:40:04Z

.github/workflows/run-test-harness.yml

This is essentially the same exact file as .github/workflows/run-functional-tests.yml and these could probably be combined and made more dynamic.

sayaliM0412 added the TypeEnhancement label Aug 29, 2023

sayaliM0412 force-pushed the github-action-DAT-15775 branch 2 times, most recently from 776d16d to 53b7302 Compare August 31, 2023 21:17

sayaliM0412 added the runFunctionalTests label Aug 31, 2023

sayaliM0412 temporarily deployed to internal August 31, 2023 21:27 — with GitHub Actions Inactive

sayaliM0412 added runFunctionalTests and removed runFunctionalTests labels Aug 31, 2023

sayaliM0412 temporarily deployed to internal August 31, 2023 21:33 — with GitHub Actions Inactive

sayaliM0412 added runFunctionalTests and removed runFunctionalTests labels Aug 31, 2023

sayaliM0412 temporarily deployed to internal August 31, 2023 21:40 — with GitHub Actions Inactive

sayaliM0412 temporarily deployed to internal September 1, 2023 13:04 — with GitHub Actions Inactive

sayaliM0412 added runFunctionalTests and removed runFunctionalTests labels Sep 1, 2023

sayaliM0412 temporarily deployed to internal September 1, 2023 13:48 — with GitHub Actions Inactive

sayaliM0412 force-pushed the github-action-DAT-15775 branch from 3352a95 to 6fec875 Compare September 1, 2023 19:19

sayaliM0412 added runFunctionalTests and removed runFunctionalTests labels Sep 1, 2023

sayaliM0412 temporarily deployed to internal September 1, 2023 19:40 — with GitHub Actions Inactive

sayaliM0412 temporarily deployed to internal September 6, 2023 15:13 — with GitHub Actions Inactive

sayaliM0412 temporarily deployed to internal September 6, 2023 15:22 — with GitHub Actions Inactive

sayaliM0412 temporarily deployed to internal September 6, 2023 15:44 — with GitHub Actions Inactive

sayaliM0412 temporarily deployed to internal September 6, 2023 16:24 — with GitHub Actions Inactive

sayaliM0412 temporarily deployed to internal September 6, 2023 16:34 — with GitHub Actions Inactive

sayaliM0412 temporarily deployed to internal September 6, 2023 16:39 — with GitHub Actions Inactive

removing liquibase-standard dir

c75d518

sayaliM0412 temporarily deployed to internal December 11, 2023 16:01 — with GitHub Actions Inactive

Revert "removing liquibase-standard dir"

fd66d15

This reverts commit c75d518.

sayaliM0412 temporarily deployed to internal December 11, 2023 16:09 — with GitHub Actions Inactive

Clean

8eca3ca

sayaliM0412 temporarily deployed to internal December 11, 2023 16:13 — with GitHub Actions Inactive

Remove not used files.

ba5ea07

filipelautert temporarily deployed to internal December 11, 2023 16:27 — with GitHub Actions Inactive

filipelautert added 3 commits December 11, 2023 13:29

Delete liquibase-standard/src/test/java/liquibase/verify/saved_state/…

91f03df

…compareGeneratedSqlWithExpectedSqlForMinimalChangesets/alterSequence/mariadb.sql Signed-off-by: filipe <flautert@liquibase.org>

Delete liquibase-standard/src/test/java/liquibase/verify/saved_state/…

116a3b0

…compareGeneratedSqlWithExpectedSqlForMinimalChangesets/createSequence/mariadb.sql Signed-off-by: filipe <flautert@liquibase.org>

Delete liquibase-standard/src/test/java/liquibase/verify/saved_state/…

5d60d39

…compareGeneratedSqlWithExpectedSqlForMinimalChangesets/dropSequence/mariadb.sql Signed-off-by: filipe <flautert@liquibase.org>

filipelautert temporarily deployed to internal December 11, 2023 16:30 — with GitHub Actions Inactive

Delete liquibase-standard/src/test/java/liquibase/verify/saved_state/…

cbef927

…compareGeneratedSqlWithExpectedSqlForMinimalChangesets/renameSequence/mariadb.sql Signed-off-by: filipe <flautert@liquibase.org>

filipelautert temporarily deployed to internal December 11, 2023 16:30 — with GitHub Actions Inactive

comment sync of master and release for now

31d9b57

sayaliM0412 temporarily deployed to internal December 11, 2023 16:33 — with GitHub Actions Inactive

comment sync of master and release for now

cac842e

sayaliM0412 temporarily deployed to internal December 11, 2023 16:34 — with GitHub Actions Inactive

comment sync of master and release for now

02d0f1a

sayaliM0412 temporarily deployed to internal December 11, 2023 16:38 — with GitHub Actions Inactive

clean code

48b532b

sayaliM0412 temporarily deployed to internal December 11, 2023 17:09 — with GitHub Actions Inactive

sayaliM0412 temporarily deployed to internal December 11, 2023 17:28 — with GitHub Actions Inactive

upload artifacts-named as this is where test-harness is downloading i…

81c579b

…t from

filipelautert approved these changes Dec 11, 2023

View reviewed changes

.github/workflows/build.yml Show resolved Hide resolved

filipelautert requested a review from StevenMassaro December 11, 2023 19:32

rberezen approved these changes Dec 11, 2023

View reviewed changes

sayaliM0412 merged commit 5afcbc9 into master Dec 11, 2023
58 of 61 checks passed

sayaliM0412 deleted the github-action-DAT-15775 branch December 11, 2023 23:36

StevenMassaro reviewed Dec 12, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAT-15775 #4780

DAT-15775 #4780

sayaliM0412 commented Aug 29, 2023 •

edited

Loading

StevenMassaro Dec 11, 2023

StevenMassaro Dec 12, 2023

sayaliM0412 Dec 12, 2023

StevenMassaro Dec 12, 2023

StevenMassaro Dec 12, 2023

sayaliM0412 Dec 12, 2023

StevenMassaro Dec 12, 2023

sayaliM0412 Dec 12, 2023

StevenMassaro Dec 12, 2023

StevenMassaro Dec 12, 2023

		latest_merge_sha=`(git rev-parse HEAD)`
		echo "latestMergeSha=${latest_merge_sha}" >> $GITHUB_OUTPUT

DAT-15775 #4780

DAT-15775 #4780

Conversation

sayaliM0412 commented Aug 29, 2023 • edited Loading

Impact

Description

Things to be aware of

Things to worry about

Additional Context

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sayaliM0412 commented Aug 29, 2023 •

edited

Loading