Optimise the logic for tableIsEmpty check constraint #4834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipelautert
changed the title
filipelautert
changed the title
suryaaki2
approved these changes
Sep 5, 2023
rberezen
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
@tati-qalified could you please check if tableIsEmpty still works as expected?
Also created https://datical.atlassian.net/browse/PD-3741 cc @filipelautert
https://docs.liquibase.com/concepts/changelogs/preconditions.html#available-preconditions
|
Fix for the test failure https://github.com/liquibase/liquibase-pro-tests/pull/969 |
|
@rberezen the precondition is working as expected with an xml format changelog. I wasn't able to find how to implement the precondition for other formats, if it's even supported, so I didn't test those cases. |
filipelautert
force-pushed
the
improve-table-is-empty-precondition
branch
from
23a5ed4
to
b9bae56
Compare
tati-qalified
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Optimise the logic for verifying if a table is empty: instead of selecting count the table, uses exists.
Things to be aware of
SQL Ansi for all databases query.
Things to worry about
NA
Additional Context
Added tests. Fixes #4734