Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update truelicense text #4853

Merged
merged 3 commits into from
Sep 13, 2023
Merged

update truelicense text #4853

merged 3 commits into from
Sep 13, 2023

Conversation

suryaaki2
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

kevin-atx
kevin-atx reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@kevin-atx kevin-atx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot just replace the AGPL license name with TrueLicense Commercial. You have to replace the verbiage associated with the license. You also need to remove the AGPL links as they are not correct.

@suryaaki2
removed agpl3.0 license
8554660 
We do not need agpl3 license as we are using Truelicense commercial
kevin-atx
kevin-atx approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@kevin-atx kevin-atx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, Surya.

@suryaaki2 suryaaki2 merged commit c486bef into master Sep 13, 2023
28 of 29 checks passed
@suryaaki2 suryaaki2 deleted the update-true-license-txt branch September 13, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-atx kevin-atx kevin-atx approved these changes

@filipelautert filipelautert filipelautert approved these changes

Assignees
No one assigned
Labels
TypeBug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suryaaki2 @kevin-atx @filipelautert