-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add '@Deprecated' annotation to update() methods #4919
Conversation
Some update() methods were missing the '@deprecated' annotation, which made the javadocs outdated.
I think it would be nice if we also add some javadoc recommending users to use CommandScope. Something like:
What do you guys think about it? cc: @tati-qalified @filipelautert |
@MalloD12 sounds good, I see that you've already merged to master, should I push the changes here or create another PR? |
Tati, this has not been not merged yet. I just merged master into your branch. So, feel free to update this one. Thanks, |
Woops, I saw "merged master into master" and thought it was the other way around. I'll update the code. |
Updated. Are we good to go? Any other suggestions? |
Nothing else from my side, thank you @tati-qalified! |
Impact
Description
Some update() methods were missing the '@deprecated' annotation, which made the javadocs outdated. I added the annotation to these methods:
Things to be aware of
This will change the javadocs documentation
Things to worry about
It's my understanding that all liquibase.update() methods are deprecated. If not, ignore this PR.