[DAT-15924] Handle AbstractSQLChange runWith checksum v8 variants #4937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
liquibase-standard/src/main/java/liquibase/util/ValidatingVisitorUtil.java
Fixed
Show fixed
Hide fixed
liquibase-standard/src/main/java/liquibase/util/ValidatingVisitorUtil.java
Fixed
Show fixed
Hide fixed
filipelautert
force-pushed
the
DAT-15924
branch
from
830473a
to
91e2f9a
Compare
filipelautert
requested review from
wwillard7800,
rberezen,
suryaaki2 and
StevenMassaro
liquibase-standard/src/main/java/liquibase/change/AbstractSQLChange.java
Outdated
Show resolved
Hide resolved
liquibase-standard/src/main/java/liquibase/util/ValidatingVisitorUtil.java
Outdated
Show resolved
Hide resolved
liquibase-standard/src/main/java/liquibase/util/ValidatingVisitorUtil.java
Outdated
Show resolved
Hide resolved
wwillard7800
approved these changes
Sep 20, 2023
4.19.0 or 4.19.1? Does it matter? |
It's 4.19.1, I confirmed during tests. |
liquibase-standard/src/main/java/liquibase/util/ValidatingVisitorUtil.java
Fixed
Show fixed
Hide fixed
liquibase-standard/src/main/java/liquibase/util/ValidatingVisitorUtil.java
Fixed
Show fixed
Hide fixed
StevenMassaro
approved these changes
Sep 20, 2023
suryaaki2
approved these changes
Sep 20, 2023
liquibase-standard/src/main/java/liquibase/util/ValidatingVisitorUtil.java
Fixed
Show fixed
Hide fixed
liquibase-standard/src/main/java/liquibase/util/ValidatingVisitorUtil.java
Fixed
Show fixed
Hide fixed
liquibase-standard/src/main/java/liquibase/util/ValidatingVisitorUtil.java
Fixed
Show fixed
Hide fixed
liquibase-standard/src/main/java/liquibase/util/ValidatingVisitorUtil.java
Fixed
Show fixed
Hide fixed
filipelautert
force-pushed
the
DAT-15924
branch
from
02ca2f1
to
5936cb7
Compare
liquibase-standard/src/main/java/liquibase/change/AbstractSQLChange.java
Dismissed
Show dismissed
Hide dismissed
liquibase-standard/src/main/java/liquibase/util/ValidatingVisitorUtil.java
Dismissed
Show dismissed
Hide dismissed
liquibase-standard/src/main/java/liquibase/util/ValidatingVisitorUtil.java
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
AbstractSqlChange checksum had the checksum calculated value changed for Liquibase versions 4.19.1 to 4.23.1 due to some changes on the way that we call it when using runWith="anything". This PR validates the v8 checksum using the alternative algorithm as a way to allow users to upgrade to checksums v9 without facing any errors or unexpected behaviours