Fix liquibase bat #4985
Merged
Fix liquibase bat #4985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
I cannot find where to assign the typeBug label to this PR. |
filipelautert
added
TypeBug
SafeToBuild
|
@erasmussen-first seems our build is broken right now, but besides that we will review this PR. Thanks for the submission! |
1: Don't error if JAVA_HOME is defined and surrounded by double-quotes 2: If auto-setting JAVA_HOME, fix double-backslash before jre 3: If auto-setting JAVA_HOME, remove quotes around JAVA_HOME
filipelautert
force-pushed
the
fix_liquibase_bat
branch
from
78b9c22
to
e1b985a
Compare
filipelautert
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
I downloaded the file and added it to a 4.23.2 installation. Executed in on powershell and cmd , with and without JAVA_HOME set and everything went fine! Thanks @erasmussen-first
suryaaki2
approved these changes
Oct 4, 2023
rberezen
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Fix environment variable handling in liquibase.bat
1: Don't error if JAVA_HOME is defined and surrounded by double-quotes
2: If auto-setting JAVA_HOME, fix double-backslash before jre
3: If auto-setting JAVA_HOME, remove quotes around JAVA_HOME
Things to be aware of
Things to worry about
Additional Context