[DAT-16006] Fixing v8 Checksum calculation issue when using sql dbms attribute #4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to changesets) - but as we were calculating checksum v9 without them, keep on ignoring them otherwise we will break v9 checksum.
…es to changesets) - but as we were calculating checksum v9 without them, keep on ignoring them otherwise we will break v9 checksum.
…that are not expected to run.
…cksum but not v9; Change from Mysql to H2 improving performance.
filipelautert
commented
Sep 29, 2023
| if (change.generateStatementsVolatile(database)) { | ||
| executor.comment("WARNING The following SQL may change each run and therefore is possibly incorrect and/or invalid:"); | ||
| } | ||
| if ((!(change instanceof DbmsTargetedChange)) || DatabaseList.definitionMatches(((DbmsTargetedChange) change).getDbms(), database, true)) { |
There was a problem hiding this comment.
Moved this check back here (before 4.22.0 it was here and not at DbmsChangeSetFilter)
filipelautert
commented
Sep 29, 2023
| for (SqlVisitor visitor : changeSet.getSqlVisitors()) { | ||
| if (!DatabaseList.definitionMatches(visitor.getApplicableDbms(), database, true)) { | ||
| visitorsToRemove.add(visitor); | ||
| } | ||
| } | ||
| for(Change change : changeSet.getChanges()){ |
There was a problem hiding this comment.
This filtering was moved back to Changeset class
filipelautert
commented
Sep 29, 2023
...on-tests/src/test/groovy/liquibase/command/core/UpgradeChecksumVersionIntegrationTest.groovy
Show resolved
Hide resolved
This was referenced Sep 29, 2023
wwillard7800
approved these changes
Sep 29, 2023
|
As noted in #4665 (comment) tested that the artifacts here seem to resolve the issue in #4665 🙏 |
StevenMassaro
approved these changes
Oct 2, 2023
...on-tests/src/test/groovy/liquibase/command/core/UpgradeChecksumVersionIntegrationTest.groovy
Show resolved
Hide resolved
suryaaki2
approved these changes
Oct 4, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Checksums (v8) are calculated differently for XML changesets with the dbms attribute on the change itself (instead of the changeset) after 4.22.0 .
Fixes #4665
Fixes #4457