Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes picocli dependency optional for core #5042

Merged
merged 1 commit into from Oct 18, 2023

Conversation

filipelautert
Copy link
Collaborator

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@filipelautert filipelautert added the enhancement New non breaking enhancements in LB label Oct 9, 2023
@filipelautert filipelautert self-assigned this Oct 9, 2023
@filipelautert filipelautert linked an issue Oct 9, 2023 that may be closed by this pull request
2 tasks
@filipelautert filipelautert marked this pull request as ready for review October 13, 2023 15:38
@landsman
Copy link

Nice!

@filipelautert filipelautert force-pushed the 4868-picocli-dependency-optional branch from 44bff76 to 5c040ab Compare October 16, 2023 13:20
@filipelautert filipelautert removed the enhancement New non breaking enhancements in LB label Oct 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@filipelautert filipelautert merged commit 1b51f96 into master Oct 18, 2023
31 of 32 checks passed
@filipelautert filipelautert deleted the 4868-picocli-dependency-optional branch October 18, 2023 17:43
@filipelautert filipelautert added this to the 1NEXT milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Picocli dependency is not published as optional dependency of liquibase-core
5 participants