New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for DB2[z] empty table precondition #5043
Merged
filipelautert
merged 7 commits into
liquibase:master
from
MichaelKern-IVV:feature/TableiIEmptyPreconditionForDB2
Jan 15, 2024
Merged
Improve support for DB2[z] empty table precondition #5043
filipelautert
merged 7 commits into
liquibase:master
from
MichaelKern-IVV:feature/TableiIEmptyPreconditionForDB2
Jan 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/MichaelKern-IVV/liquibase into MichaelKern-IVV-feature/TableiIEmptyPreconditionForDB2
MalloD12
added
the
SafeToBuild
Indicates that a particular PR contains changes which are safe to build using GitHub actions
label
Oct 13, 2023
MalloD12
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me. I manually test it against a DB2 instance by deploying a create table change and then the below changeset:
<changeSet id="tableIsEmptyShouldFail" author="flautert">
<preConditions onFail="MARK_RAN">
<tableIsEmpty tableName="csvdata"/>
</preConditions>
<!-- if table is dropped then next changesets will fail, thus it is an indirect check -->
<dropTable tableName="csvdata" />
</changeSet>
Which dropped the csvdata
table successfully. See below:
Thanks @MichaelKern-IVV!
filipelautert
approved these changes
Oct 16, 2023
suryaaki2
approved these changes
Oct 16, 2023
rberezen
approved these changes
Oct 17, 2023
Signed-off-by: filipe <flautert@liquibase.org>
filipelautert
requested changes
Oct 23, 2023
liquibase-standard/src/main/java/liquibase/sqlgenerator/core/TableIsEmptyGenerator.java
Outdated
Show resolved
Hide resolved
filipelautert
added
SafeToBuild
Indicates that a particular PR contains changes which are safe to build using GitHub actions
and removed
SafeToBuild
Indicates that a particular PR contains changes which are safe to build using GitHub actions
labels
Oct 23, 2023
Kudos, SonarCloud Quality Gate passed! |
filipelautert
had a problem deploying
to
external
December 13, 2023 12:45
— with
GitHub Actions
Error
MichaelKern-IVV
temporarily deployed
to
external
December 23, 2023 16:07
— with
GitHub Actions
Inactive
filipelautert
had a problem deploying
to
external
January 15, 2024 19:03
— with
GitHub Actions
Error
filipelautert
temporarily deployed
to
external
January 15, 2024 19:09
— with
GitHub Actions
Inactive
filipelautert
approved these changes
Jan 15, 2024
filipelautert
changed the title
Support the empty table precondition for DB2
Improve support for DB2[z] empty table precondition
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DBDB2LUW
DBDB2Z
SafeToBuild
Indicates that a particular PR contains changes which are safe to build using GitHub actions
TypeEnhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Adds statements for DB2 to the TableIsEmptyGenerator