Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing a ChangeSetService for modification of model objects DAT-16079 #5117

Merged
merged 11 commits into from Nov 6, 2023

Conversation

wwillard7800
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

ChangeSet createChangeSet(String id, String author, boolean alwaysRun, boolean runOnChange,
String filePath, String contextFilter, String dbmsList,
String runWith, String runWithSpoolFile, boolean runInTransaction,
ObjectQuotingStrategy quotingStrategy, DatabaseChangeLog databaseChangeLog);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'quotingStrategy' is never used.
Copy link
Collaborator

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @wwillard7800 - could you please take a look at the CodeQL warnings?

DAT-16079
Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wwillard7800 wwillard7800 merged commit 8fb73df into master Nov 6, 2023
29 of 32 checks passed
@wwillard7800 wwillard7800 deleted the DAT-16079 branch November 6, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants