New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing a ChangeSetService for modification of model objects DAT-16079 #5117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquibase-standard/src/main/java/liquibase/changeset/ChangeSetService.java
Fixed
Show fixed
Hide fixed
liquibase-standard/src/main/java/liquibase/changeset/ChangeSetService.java
Dismissed
Show dismissed
Hide dismissed
ChangeSet createChangeSet(String id, String author, boolean alwaysRun, boolean runOnChange, | ||
String filePath, String contextFilter, String dbmsList, | ||
String runWith, String runWithSpoolFile, boolean runInTransaction, | ||
ObjectQuotingStrategy quotingStrategy, DatabaseChangeLog databaseChangeLog); |
Check notice
Code scanning / CodeQL
Useless parameter Note
The parameter 'quotingStrategy' is never used.
liquibase-standard/src/main/java/liquibase/changeset/ChangeSetService.java
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @wwillard7800 - could you please take a look at the CodeQL warnings?
DAT-16079
filipelautert
approved these changes
Oct 25, 2023
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Things to be aware of
Things to worry about
Additional Context