Do not warn when env var matches argument alias (DAT-16117) #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les when the environment variable matches an alias.
abrackx
requested review from
StevenMassaro,
filipelautert and
MalloD12
and removed request for
filipelautert
StevenMassaro
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Are there any tests for this code? Could you add to them or create one for this case?
Also, @wwillard7800 , didn't you make a ticket for this recently? I could be imagining things.
There's none for this particular case since it's integrating the configuration with the env var provider. But yeah, the test cases in this area are very light. I'll see what I can do. Edit: done! |
abrackx
changed the title
filipelautert
approved these changes
Nov 6, 2023
wwillard7800
approved these changes
Nov 6, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Do not warn on unrecognized LIQUIBASE_ environment variables when the environment variable matches an alias.
Things to be aware of
Things to worry about
Additional Context