Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4464 fix generated default column value using in PostgreSQL and Oracle for char/clob data types #5202

Merged
merged 15 commits into from
Jan 12, 2024
Merged

4464 fix generated default column value using in PostgreSQL and Oracle for char/clob data types #5202

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0e19a95
4464 fix generated default column value using in PostgreSQL for char/…
LonwoLonwo Nov 13, 2023
4989304
Merge branch 'master' into 4464-fix-generated-default-column-value-us…
LonwoLonwo Nov 13, 2023
e775767
Merge branch 'master' into 4464-fix-generated-default-column-value-us…
MalloD12 Nov 23, 2023
7f8eef5
Merge branch '4464-fix-generated-default-column-value-using-in-PG' of…
MalloD12 Nov 24, 2023
7a9c8e7
Merge branch 'master' into 4464-fix-generated-default-column-value-us…
LonwoLonwo Dec 22, 2023
5b0237a
4464 code style: add constants
LonwoLonwo Dec 22, 2023
08b1c3a
Merge branch 'master' into LonwoLonwo-4464-fix-generated-default-colu…
MalloD12 Dec 26, 2023
307c2de
Merge branch '4464-fix-generated-default-column-value-using-in-PG' of…
MalloD12 Dec 26, 2023
cb0908a
4464 add Oracle test; fix conditions
LonwoLonwo Dec 26, 2023
a5ea39f
Merge branch '4464-fix-generated-default-column-value-using-in-PG' of…
MalloD12 Dec 26, 2023
6e7e68f
Update command argument.
MalloD12 Dec 26, 2023
16e3352
Merge branch 'master' into 4464-fix-generated-default-column-value-us…
LonwoLonwo Dec 27, 2023
2542735
Merge branch 'master' into 4464-fix-generated-default-column-value-us…
MalloD12 Jan 3, 2024
a46ecd5
Fix tests
filipelautert Jan 3, 2024
4d94fec
Remove quotes returned by Oracle around fields for virtColumnDef
filipelautert Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion liquibase-integration-tests/src/test/java/liquibase/dbtest/oracle/OracleIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ public void testChangeLogGenerationForTableWithGeneratedColumn() throws Exceptio
String textToTest = "GENERATED ALWAYS AS (QTY * PRICE)";

Scope.getCurrentScope().getSingleton(ExecutorService.class).getExecutor("jdbc", getDatabase()).execute(new RawSqlStatement(
String.format("CREATE TABLE GENERATED_COLUMN_TEST(QTY INT, PRICE INT, TOTALVALUE INT %s);", textToTest)));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there :)
The assertion failed as it is not able to find our sql fragment. The generated SQL below is:

<column defaultValueComputed="GENERATED ALWAYS AS (&quot;QTY&quot;*&quot;PRICE&quot;)" name="TOTALVALUE" type="NUMBER(*, 0)"/>

So in my next commit I'm removing " from virtColumnDef variable... and seems it works. I wonder if this is the best solution @LonwoLonwo @MalloD12 , but at least it is working now :)

String.format("CREATE TABLE GENERATED_COLUMN_TEST(QTY INT, PRICE INT, TOTALVALUE INT %s)", textToTest)));

ByteArrayOutputStream baos = new ByteArrayOutputStream();
new CommandScope(GenerateChangelogCommandStep.COMMAND_NAME)
Expand Down