Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #5266: comma separated dbms-attribute for createProcedure-change triggers validation-check #5267

Merged
merged 8 commits into from Dec 20, 2023
Merged

fix #5266: comma separated dbms-attribute for createProcedure-change triggers validation-check #5267

merged 8 commits into from Dec 20, 2023

Conversation

jclohmann
Copy link
Contributor

@jclohmann jclohmann commented Nov 21, 2023 •
edited by MalloD12

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

As described in the issue #5266, I split the definition string before calling the existing validation-code.

Fixes #5266

Things to be aware of

Things to worry about

Additional Context

@jclohmann jclohmann marked this pull request as ready for review November 21, 2023 16:26
@MalloD12 MalloD12 self-assigned this Nov 27, 2023
@MalloD12 MalloD12 self-requested a review November 27, 2023 18:06
MalloD12
MalloD12 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Review and testing results:

Dbms attribute has been fixed for stored logic change objects. This is not only applicable for CreateProcedure, it also affects CreateTrigger, CreateFunction, etc. I tested it with CreateProcedure and CreateTrigger and both are working as expected now.

Things to be aware of:

  • None

Things to worry about:

  • None

@MalloD12 MalloD12 added the SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions label Nov 27, 2023
@MalloD12 MalloD12 added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Nov 27, 2023
@filipelautert filipelautert added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Nov 28, 2023
@rberezen rberezen added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels Dec 4, 2023
@filipelautert filipelautert added this to the 1NEXT milestone Dec 20, 2023
@filipelautert filipelautert merged commit 7f31f3e into liquibase:master Dec 20, 2023
63 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalloD12 MalloD12 MalloD12 approved these changes

@filipelautert filipelautert filipelautert approved these changes

@rberezen rberezen rberezen approved these changes

@suryaaki2 suryaaki2 Awaiting requested review from suryaaki2

Assignees

@MalloD12 MalloD12

Labels
SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions TypeBug
Projects
Liquibase Open Source
Status: Done
Milestone
v4.26.0
Development

Successfully merging this pull request may close these issues.

createProcedure with multiple comma separated dbms triggers validation-check
4 participants
@jclohmann @filipelautert @rberezen @MalloD12