Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.24 Regression] Checksum error while performing update and then rollback with a changelog parameter - Fix for issue #5278 #5283

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

ebussieres
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR fixes a bug introduced in 4.24.0. This PR fixes issue #5278

Things to be aware of

Things to worry about

Additional Context

@EvaristeGalois11
Copy link
Contributor

Just wanted to add: would it be possible to backport this fix to 4.24.X? Spring boot 3.2.X is using that version and they have a policy of updating only to patch releases, so it could permit them to fix it without having to wait for 3.3.0

@ebussieres
Copy link
Contributor Author

Just wanted to add: would it be possible to backport this fix to 4.24.X? Spring boot 3.2.X is using that version and they have a policy of updating only to patch releases, so it could permit them to fix it without having to wait for 3.3.0

Sure, what is the branch for the 4.24.x release ?

@EvaristeGalois11
Copy link
Contributor

Sorry my bad, it was a message for the liquibase devs for when they will process this PR.

@ebussieres ebussieres changed the title Fix for issue #5278 [4.24 Regression] Checksum error while performing update and then rollback with a changelog parameter - Fix for issue #5278 Nov 27, 2023
@filipelautert filipelautert self-assigned this Nov 28, 2023
@filipelautert
Copy link
Collaborator

Just wanted to add: would it be possible to backport this fix to 4.24.X? Spring boot 3.2.X is using that version and they have a policy of updating only to patch releases, so it could permit them to fix it without having to wait for 3.3.0

Hello @EvaristeGalois11 - this fix will probably be included with 4.26.0 . Sorry but liquibase don't have a policy to release minor versions with fixes for previous versions yet.

@filipelautert
Copy link
Collaborator

@ebussieres thanks for the fix! so seems we forgot to add the parameter to some commands... thanks for spotting that!

Copy link
Collaborator

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds missing arguments to Liquibase class that were missing during a fix for issue #4491 + it adds tests!

@filipelautert filipelautert added this to the 1NEXT milestone Dec 8, 2023
@filipelautert filipelautert merged commit 8ec74b0 into liquibase:master Dec 8, 2023
64 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants