Global flag to restore behaviour of not failing on duplicated changeset identifiers #5296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se to behavior as it did before version 4.19.1 (PR #3790)
2 tasks
filipelautert
changed the title
Added logic in the class to handle duplicate changeset identifiers based on a global configuration flag. This change provides an allowance for duplicated changesets but only when the flag is enabled in GlobalConfiguration. This was done to maintain backward compatibility with versions prior to 4.19.1 where ignoring duplicates was the default behavior.
This commit refactors and extends the testAllProvidedChangesetsAreLoaded test in XMLChangeLogSAXParserTest.groovy. The change aligns the test with a new feature, supporting the duplication of changeset identifiers, thereby improving the flexibility and scalability of the system. Additional conditional statements were included in the test function to distinguish between duplicated and non-duplicated changeset identifiers. Two scenarios were added in where clause to test both situations.
filipelautert
changed the title
rberezen
approved these changes
Dec 6, 2023
|
Documentation link to go live soon: https://docs.liquibase.com/parameters/allow-duplicated-changeset-identifiers.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Adjust duplicate changeset validation
Added logic in the class to handle duplicate changeset identifiers based on a global configuration flag. This change provides an allowance for duplicated changesets but only when the flag is enabled in GlobalConfiguration. This was done to maintain backward compatibility with versions prior to 4.19.1 where ignoring duplicates was the default behavior (PR #3790) .
when this flag is set to true Liquibase won't fail with message:
Doc review
New global flag: --allow-duplicated-changeset-identifiers=<false|true>
Fix #3881