Updated PrimaryKeyExistsPrecondition to require table name for H2 databases #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abases This commit updates the PrimaryKeyExistsPrecondition class in order to throw an exception when no table name is provided while using H2 database. This change has been done because the H2 database driver requires a table name to be specified for searching a primary key.
filipelautert
added
TypeEnhancement
DocNeeded
enhancement
rberezen
approved these changes
Dec 7, 2023
…-when-used-with-h2-2x
…r MySQL when tableName is not provided. - Update test. - Update test data.
… is not specified to H2 and MySQL test suites. - Add integration test to validate no error is returned for others DBs.
- Added integration test for these new applied DBs. - Update existent abstract integration test.
MalloD12
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Code changes looks good to me. I have add some other DBs so precondition returns the same given error and added some integration tests.
@rberezen Would you mind looking at the test cases added and see if they look good enough for you?
Thanks,
Daniel.
…-when-used-with-h2-2x
filipelautert
commented
Dec 11, 2023
liquibase-integration-tests/src/test/java/liquibase/dbtest/AbstractIntegrationTest.java
Show resolved
Hide resolved
filipelautert
deleted the
3643-primarykeyexists-precondition-crashes-when-used-with-h2-2x
branch
|
Docs internal: https://datical.atlassian.net/browse/PD-4392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
This PR updates the PrimaryKeyExistsPrecondition in order to throw a friendly message when no table name is provided while using H2 database. This change has been done because the H2 database driver requires a table name to be specified for searching a primary key.
Doc notes
This precondition fails on databases which don't support the null as third parameter Documentation is required on https://docs.liquibase.com/concepts/changelogs/preconditions.html mentioning that due to JDBC driver limitations, is some databases such as H2 the tableName is required.
Fixes #3643