map testcontainers to random available host port #5462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenMassaro
temporarily deployed
to
internal
GitHub Actions
Inactive
StevenMassaro
temporarily deployed
to
internal
GitHub Actions
Inactive
StevenMassaro
changed the title
StevenMassaro
temporarily deployed
to
internal
GitHub Actions
Inactive
MalloD12
reviewed
Jan 12, 2024
| @@ -90,6 +90,12 @@ | |||
| <groupId>junit</groupId> | |||
| <artifactId>junit</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Just out of curiosity, why is this dependency needed on extension-testing module?
There was a problem hiding this comment.
I'm using it to find an available port, see here: https://github.com/liquibase/liquibase/pull/5462/files#diff-dc9fce8ed63f202210608132cc78af8ecb6ceb3db2dbfcdb3984dfb79f7c6a0fR135
filipelautert
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Things to be aware of
Things to worry about
Additional Context