Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automatically run dropall before and after all integration tests #5493

Merged
merged 4 commits into from Jan 22, 2024
Merged

automatically run dropall before and after all integration tests #5493

merged 4 commits into from Jan 22, 2024

Conversation

StevenMassaro
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@StevenMassaro StevenMassaro changed the title run dropall after all tests automatically run dropall after all tests Jan 22, 2024
@StevenMassaro StevenMassaro changed the title automatically run dropall after all tests automatically run dropall after all integration tests Jan 22, 2024
@StevenMassaro StevenMassaro marked this pull request as ready for review January 22, 2024 19:28
@StevenMassaro StevenMassaro changed the title automatically run dropall after all integration tests automatically run dropall before and after all integration tests Jan 22, 2024
filipelautert
filipelautert approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@StevenMassaro StevenMassaro merged commit 7197262 into master Jan 22, 2024
28 checks passed
@StevenMassaro StevenMassaro deleted the fix-test-2 branch January 22, 2024 19:39
abrackx added a commit that referenced this pull request Jan 23, 2024
@abrackx
Revert "automatically run dropall before and after all integration te…
1cbbb10 
…sts (#5493)"

This reverts commit 7197262.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipelautert filipelautert filipelautert approved these changes

@abrackx abrackx abrackx approved these changes

Assignees
No one assigned
Labels
TypeTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StevenMassaro @filipelautert @abrackx