Adding maven wrapper support #5500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: filipe <flautert@liquibase.org>
filipelautert
temporarily deployed
to
internal
GitHub Actions
Inactive
filipelautert
requested review from
sayaliM0412,
rberezen,
jnewton03 and
suryaaki2
|
Created this new as the previous PR was clashing with a very old branch from pro . |
|
@filipelautert : do we want this to be QA'd ? |
@sayaliM0412 yes please! |
who is going to QA'd it? DevOps, Devs, QAs? cc @filipelautert @sayaliM0412 |
rberezen
reviewed
Jan 29, 2024
| mvn versions:set "-DnewVersion=${{ needs.setup.outputs.thisBranchName }}-SNAPSHOT" | ||
| #mvn versions:set "-DnewVersion=${{ inputs.branchName }}-SNAPSHOT" | ||
| ./mvnw versions:set "-DnewVersion=${{ needs.setup.outputs.thisBranchName }}-SNAPSHOT" | ||
| #./mvnw versions:set "-DnewVersion=${{ inputs.branchName }}-SNAPSHOT" |
There was a problem hiding this comment.
should we leave commented line?
All of the above? |
rberezen
approved these changes
Jan 29, 2024
|
did a quick check locally, works good! |
filipelautert
temporarily deployed
to
internal
GitHub Actions
Inactive
filipelautert
temporarily deployed
to
internal
GitHub Actions
Inactive
|
Internal documentation ticket: https://datical.atlassian.net/browse/PD-4220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Adding maven wrapper support and using it to build Liquibase instead of maven installed by github actions.
DOCS notes: after merging this PR we will need to fix documentation at https://contribute.liquibase.com/code/get-started/env-setup/ to get rid of step 2 and update step 3
Partially fixes #5334 .