Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle java.lang.StackOverflowError when running generate-changelog (DAT-16812) #5545

Merged
merged 4 commits into from Feb 14, 2024
Merged

Handle java.lang.StackOverflowError when running generate-changelog (DAT-16812) #5545

merged 4 commits into from Feb 14, 2024

Conversation

filipelautert
Copy link
Collaborator

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

@filipelautert
fix: Validate the error code and not the whole error message as peopl…
c219463 
…e using other locales will get different descriptions.
@filipelautert
feat: Implements skipObjectSorting option in GenerateChangelog/DiffCh…
86e4442 
…angelog

* adds informative message if we reach a StackOverflow.
* Sonar Cleanups
@filipelautert filipelautert self-assigned this Feb 1, 2024
@filipelautert filipelautert marked this pull request as ready for review February 1, 2024 21:52
@StevenMassaro StevenMassaro changed the title Handle java.lang.StackOverflowError when running generate-changelog Handle java.lang.StackOverflowError when running generate-changelog (DAT-16812) Feb 5, 2024
@suryaaki2 suryaaki2 merged commit e2f9875 into master Feb 14, 2024
31 of 32 checks passed
@suryaaki2 suryaaki2 deleted the DAT-16812 branch February 14, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwillard7800 wwillard7800 wwillard7800 approved these changes

@StevenMassaro StevenMassaro StevenMassaro approved these changes

@suryaaki2 suryaaki2 suryaaki2 approved these changes

Assignees

@filipelautert filipelautert

Labels
TypeEnhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@filipelautert @wwillard7800 @StevenMassaro @suryaaki2