Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of snapshot control creation for snapshotReference command DAT-16683 #5548

Merged
merged 2 commits into from Feb 14, 2024

Conversation

wwillard7800
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@wwillard7800 wwillard7800 requested a deployment to internal February 1, 2024 22:22 — with GitHub Actions Abandoned
@@ -53,27 +53,13 @@ public void adjustCommandDefinition(CommandDefinition commandDefinition) {
commandDefinition.setShortDescription("Capture the current state of the database");
}

private CatalogAndSchema[] parseSchemas(Database database, String... schemas) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method was duplicated? Nice catch

@wwillard7800 wwillard7800 merged commit 04ebe08 into master Feb 14, 2024
32 of 34 checks passed
@wwillard7800 wwillard7800 deleted the DAT-16683 branch February 14, 2024 19:15
@wwillard7800 wwillard7800 requested a deployment to internal February 14, 2024 19:42 — with GitHub Actions Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants