Fix unique constraint and primary key generator issues for Postgres and H2

[Guschtel]

…the "using index" clause for the h2 database

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #5410
Fixes #1384

Things to be aware of

Things to worry about

Additional Context

[Guschtel]

Fixes #5410

@MalloD12 can you please advise if that is what you are expecting?

If so, I can have a look at #1384 in a similar way and add tests.

[MalloD12]

Hi @Guschtel,

Code changes look good to me. The only thing I would ask is whether it's possible to instead of creating a Java class for tests we do it as a groovy test class. For new test suites, we tried to use that language.

Test would look like:

 @Unroll
 def  "test unique constraint using index for #database database"() {
 given:
        AddUniqueConstraintStatement statement = new AddUniqueConstraintStatement(null, null, TABLE_NAME, new ColumnConfig[]{new ColumnConfig().setName(COLUMN_NAME), new ColumnConfig().setName(COLUMN_NAME2)}, CONSTRAINT_NAME);
        statement.setForIndexName(INDEX_NAME);
then:
            assertEquals(expectedSql, this.generatorUnderTest.generateSql(statement, database, null)[0].toSql(), "Failed for " + database.getShortName()))
where:
database | expectedSql
new H2Database() |  "ALTER TABLE AddUQTest ADD CONSTRAINT UQ_TEST UNIQUE (colToMakeUQ, colToMakeUQ2)"
....       
    }

Thanks,
Daniel.

[Guschtel]

Fixes #1384 and #5410

@MalloD12 have a look again, I tried to change the tests to Spock tests. First time using Spock, so please be kind if there's room to improve. :D
I didn't really find a way to parameterize the tests as i'm used to do it with JUnit, so i flattened out all possible cases.

I Also added the changes from #1384 and testcases for that.

[MalloD12]

Approved.

Code changes look good to me. Thank you @Guschtel for submitting this PR to fix two issues. Also, thank you for changing the tests format and use Spock (Groovy).

Build and most of the tests have been successfully executed (except functional test which seems to be failing for a non-related reason).

Thanks,
Daniel.