chunk long strings on insert for Oracle (DAT-16774) #5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenMassaro
temporarily deployed
to
internal
GitHub Actions
Inactive
wwillard7800
approved these changes
Feb 5, 2024
filipelautert
previously requested changes
Feb 7, 2024
| import liquibase.statement.DatabaseFunction; | ||
| import liquibase.util.StringUtil; | ||
|
|
||
| import java.math.BigInteger; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
| import java.util.Locale; | ||
|
|
||
| @DataTypeInfo(name="char", aliases = {"java.sql.Types.CHAR", "bpchar", "character"}, minParameters = 0, maxParameters = 1, priority = LiquibaseDataType.PRIORITY_DEFAULT) |
There was a problem hiding this comment.
The issue mentions CLOB, but the change is being done to char (and varchar by extension). Should it also be applied to clob or the description could be changed?
There was a problem hiding this comment.
Liquibase treats it like a varchar insert, not a clob, because the Java data type is a string. This line is where Liquibase infers the type to be a CharType, despite the insert going into a clob column: https://github.com/liquibase/liquibase/blob/master/liquibase-standard/src/main/java/liquibase/sqlgenerator/core/InsertGenerator.java#L73
suryaaki2
approved these changes
Feb 8, 2024
StevenMassaro
dismissed
filipelautert’s stale review
Filipe is on PTO and approved this PR via slack message to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Oracle forbids values longer than 4000 characters on an insert statement into a clob type column. This PR introduces a workaround which chunks the long string into 4000 character chunks.
Things to be aware of
Things to worry about
If the string chunking code doesn't handle special characters properly, it is possible that you could end up with a string chunk that is longer than 4000 characters, causing an exception. However, this was also the behavior prior to this fix, so the impact is neutral in this case.
Additional Context