Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards compatibility for procedureBody in createProcedureChange #5583

Merged
merged 4 commits into from Mar 5, 2024

Conversation

StevenMassaro
Copy link
Contributor

@StevenMassaro StevenMassaro commented Feb 8, 2024

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #5475

Things to be aware of

Things to worry about

Additional Context

@MalloD12 MalloD12 changed the title add backwards compatibility for procedureBody in createProcedureChange Add backwards compatibility for procedureBody in createProcedureChange Feb 8, 2024
@MalloD12 MalloD12 self-requested a review February 8, 2024 23:15
@MalloD12 MalloD12 self-assigned this Feb 8, 2024
@MalloD12 MalloD12 marked this pull request as ready for review February 8, 2024 23:15
Copy link
Contributor

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @StevenMassaro!

Copy link
Collaborator

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting fix!

@filipelautert filipelautert added this to the 1NEXT milestone Feb 26, 2024
@filipelautert filipelautert merged commit bff7204 into master Mar 5, 2024
32 of 33 checks passed
@filipelautert filipelautert deleted the fix-issue-5475-steve branch March 5, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Backward compatibility of createProcedure is broken
4 participants