New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format spring package. #5597
Format spring package. #5597
Conversation
liquibase-standard/src/main/java/liquibase/integration/spring/SpringLiquibase.java
Fixed
Show fixed
Hide fixed
…sashour-format
… says is deprecated in javadoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Formatting changes look good to me. I removed a deprecated set method and its related get method as well, since they were not used and there was a codeQL scan issue reported (due to an unused argument).
No builds or test checks issues reported.
liquibase-standard/src/main/java/liquibase/integration/spring/MultiTenantSpringLiquibase.java
Outdated
Show resolved
Hide resolved
@@ -60,72 +62,88 @@ | |||
protected final Logger log = Scope.getCurrentScope().getLog(SpringLiquibase.class); | |||
protected String beanName; | |||
|
|||
protected ResourceLoader resourceLoader; | |||
@Getter | |||
@Setter |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
The current code sometimes uses 2-space indentation and 4-space one.
I think it makes sense to format the spring package (for now) for 4-space indentation, as a preparation to work on a PR for that package.
Please let me know if 2-space one is preferred.