Add CustomChangeChecksum interface #5649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new optional interface: CustomChangeChecksum, that you can implement on any CustomChange. Will let you configure how the checksum for your specific change will be calculated, if you're not happy with the default. Closes liquibase#5478
MalloD12
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Approved.
Nothing to add here, this looks ok to me as well. Thanks you, @robinjhector for this PR!
|
Hey! Is this ready to be merged? :) |
|
Hi @robinjhector, We still need some other team members to review and test it. Hopefully, this will be happening soon. Thank you for your patience, |
filipelautert
approved these changes
Mar 21, 2024
rberezen
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Adds a new optional interface: CustomChangeChecksum, that you can implement on any CustomChange.
Will let you configure how the checksum for your specific change will be calculated, if you're not happy with the default.
See discussion in #5478
Closes #5478
Things to be aware of
As previously stated, introduces the
CustomChangeChecksuminterface which you can add to yourCustomChangeimplementation, in order to calculate your own checksum for your change. This will be a non-breaking change since the interface is completely optional.The technical impact is that
CustomChangeWrapperwill look and see if the custom change implements the new interface, and then call thegenerateChecksumfrom that specific interface. If not, use the default one (via AbstractChange)Things to worry about
N/A
Additional Context
N/A
Question: Who updates the documentation to include this new interface?