User lombok Getter and Setter. #5658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems lombok generates `get` for Boolean instead of `is`.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
liquibase-standard/src/main/java/liquibase/sql/CallableSql.java
Dismissed
Show dismissed
Hide dismissed
MalloD12
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Approved.
This looks ok to me. If you are planning to keep doing these changes for some other files I would recommend you to go in some specific order, maybe in an upcoming PR to keep adding Lombok annotations to the remaining liquibase-standard module files, and once finish with this module (which is the bigger) then continue with others.
Thanks,
Daniel.
filipelautert
approved these changes
Mar 26, 2024
rberezen
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step to use lombok Getter and Setter, as hinted in another PR.
Not all potential changes are done, because the PR would be huge. Please advise if this is fine, or project-wide changes should also be added.