New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default implementation of handleInvalidEmptyPreconditionCase added in AbtractFormattedChangeLogParser to avoid breaking extensions #5660
Conversation
…attedSqlChangeLogParser. - Added default handleInvalidEmptyPreconditionCase implementation in AbstractFormattedChangeLogParser.
@@ -610,6 +608,23 @@ | |||
return resourceAccessor.getExisting(physicalChangeLogLocation).openInputStream(); | |||
} | |||
|
|||
protected void handleInvalidEmptyPreconditionCase(ChangeLogParameters changeLogParameters, ChangeSet changeSet, Matcher preconditionMatcher) throws ChangeLogParseException { |
Check notice
Code scanning / CodeQL
Useless parameter Note
@@ -610,6 +608,23 @@ | |||
return resourceAccessor.getExisting(physicalChangeLogLocation).openInputStream(); | |||
} | |||
|
|||
protected void handleInvalidEmptyPreconditionCase(ChangeLogParameters changeLogParameters, ChangeSet changeSet, Matcher preconditionMatcher) throws ChangeLogParseException { |
Check notice
Code scanning / CodeQL
Useless parameter Note
Thanks, @MalloD12 for such a quick fix!
And left SQL-specific code in the |
Ohh, I see. I get it now. Sure, I can do that @vitaliimak. |
…mpty. - Added back handleInvalidEmptyPreconditionCase specific implemenation in FormattedSqlChangeLogParser class.
Impact
Description
Recently with the merge of this PR the team has noticed this is breaking extensions, so just move the code implementation of
handleInvalidEmptyPreconditionCase
to the abstract class which should fix this issue if no extension overrides this method.Things to be aware of
Things to worry about
Additional Context