Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception handler for when a service cannot be loaded #5667

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Exception handler for when a service cannot be loaded #5667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion liquibase-standard/src/main/java/liquibase/servicelocator/StandardServiceLocator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,22 @@ public <T> List<T> findInstances(Class<T> interfaceType) throws ServiceNotFoundE
log.fine("Loaded "+interfaceType.getName()+" instance "+service.getClass().getName());
allInstances.add(service);
} catch (Throwable e) {
log.info("Cannot load service", e);
new ServiceLoadExceptionHandler().handleException(e);
log.fine(e.getMessage(), e);
}
}

return Collections.unmodifiableList(allInstances);

}

/**
* Exception handler for when a service cannot be loaded. Created as an inner class so logs can be suppressed if desired.
*/
static class ServiceLoadExceptionHandler {
void handleException(Throwable e) {
Logger log = Scope.getCurrentScope().getLog(getClass());
log.info("Cannot load service", e);
}
}
}