Improve deferrable validation for AddForeignKey constraints generator

[alero]

This is an effort to minimize the clutter in the config and the support hsqldb in junit developer testing with the same changesets that are using in Postgre in production/integration testing

[ro-rah]

Hi @alero ,

Would you resolve branch conflict and consider adding tests for this PR? Here's some guidance on that below:

Thanks for your pull request!

Here’s what happens next:

A member of the Liquibase team will take a look at your contribution and may suggest:

• Changes based on guidelines for PR submission
• Additional tests (unit and/or integration)
• Provide other feedback, like requesting changes.

The PR will be prioritized according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

[codecov]

Codecov Report

Merging #567 into master will decrease coverage by 0.01%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##             master     #567      +/-   ##
============================================
- Coverage     47.72%   47.71%   -0.02%     
- Complexity     7474     7476       +2     
============================================
  Files           757      757              
  Lines         36274    36283       +9     
  Branches       6625     6627       +2     
============================================
- Hits          17312    17311       -1     
- Misses        16659    16663       +4     
- Partials       2303     2309       +6     

Impacted Files	Coverage Δ	Complexity Δ
...ore/src/main/java/liquibase/database/Database.java	100.00% <ø> (ø)	1.00 <0.00> (ø)
...ain/java/liquibase/database/core/MockDatabase.java	35.22% <0.00%> (-0.21%)	50.00 <0.00> (ø)
...ase/change/core/AddForeignKeyConstraintChange.java	71.42% <20.00%> (-2.30%)	50.00 <2.00> (+2.00)	⬇️
...nerator/core/AddForeignKeyConstraintGenerator.java	60.71% <57.14%> (-2.75%)	12.00 <0.00> (ø)
.../java/liquibase/database/AbstractJdbcDatabase.java	58.04% <100.00%> (+0.07%)	213.00 <1.00> (+1.00)
...re/src/main/java/liquibase/util/ISODateFormat.java	77.08% <0.00%> (-2.09%)	15.00% <0.00%> (-1.00%)
...e/src/main/java/liquibase/util/DependencyUtil.java	91.22% <0.00%> (-0.88%)	0.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd55e14...91eeebc. Read the comment docs.

[ro-rah]

@alero thanks for getting rid of the merge conflict! I'll size it as a medium, but happy to size it low if we get tests added.

[filipelautert]

Hello @alero ! A lot changed in the last years on Liquibase. Is this change still required?

[alero]

Hi @filipelautert we still use this adaption and have actually forked it last month again to be up to date with latest releases

[filipelautert]

@alero ! Thanks for the quick answer. Do you think you can fix the conflicts (as we renamed liquibase-core to liquibase-standard and so on) so I can keep on moving this one along?

[filipelautert]

Hello @alero ! I fixed the conflicts and tried to push the fix to your master branch but I don't have permission to do so. Would you be able to grant permission or fix the conflicts ?

[alero]

Hello @filipelautert I have added you to the repo, so should be able to push now and thank you for the support.

[filipelautert]

Hello @filipelautert I have added you to the repo, so should be able to push now and thank you for the support.

Thanks , almost there! But seems the branch is protected and I can't push to your master anyway, so I created PR https://github.com/alero/liquibase/pull/1 in your repo to your master 🤣 could you approve and merge it?

[alero]

approved and merged it to master

[filipelautert]

7 years later it's still alive!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

77.4% Coverage
0.0% Duplication