Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5507-performance_improvements #5670

Merged
merged 1 commit into from Mar 18, 2024
Merged

5507-performance_improvements #5670

merged 1 commit into from Mar 18, 2024

Conversation

filipelautert
Copy link
Collaborator

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

feat: use commons-lang3 library to improve random string generation by ~30% .

partially fix #5507

@filipelautert filipelautert self-assigned this Mar 7, 2024
@filipelautert filipelautert linked an issue Mar 7, 2024 that may be closed by this pull request
Performance degradation when switching from v3.6.3 to v4.25.1 #5507
Closed
@filipelautert filipelautert marked this pull request as ready for review March 13, 2024 13:50
MalloD12
MalloD12 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filipelautert filipelautert merged commit 3daa688 into master Mar 18, 2024
36 of 37 checks passed
@filipelautert filipelautert deleted the 5507-performance_improvements branch March 18, 2024 14:12
@filipelautert filipelautert added this to the 1NEXT milestone Mar 18, 2024
@filipelautert filipelautert mentioned this pull request Mar 18, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rberezen rberezen rberezen approved these changes

@MalloD12 MalloD12 MalloD12 approved these changes

@suryaaki2 suryaaki2 Awaiting requested review from suryaaki2

Assignees

@filipelautert filipelautert

Labels
TypeEnhancement
Projects
Liquibase Open Source
Status: Done
Milestone
v4.27.0
Development

Successfully merging this pull request may close these issues.

Performance degradation when switching from v3.6.3 to v4.25.1
3 participants
@filipelautert @rberezen @MalloD12