Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ignore property to includeAll XSD (DAT-14921) #5686

Merged
merged 2 commits into from Mar 21, 2024
Merged

add ignore property to includeAll XSD (DAT-14921) #5686

merged 2 commits into from Mar 21, 2024

Conversation

StevenMassaro
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

The ignore code has existed for a long time for includeAll, but it was not part of the XSD.

Things to be aware of

Things to worry about

Additional Context

abrackx
abrackx approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@abrackx abrackx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an xml test for this or do you think it's appropriately covered already?

@StevenMassaro
Copy link
Contributor Author

Should we add an xml test for this or do you think it's appropriately covered already?

I can add a test, good idea.

@StevenMassaro StevenMassaro merged commit 2060779 into master Mar 21, 2024
32 of 34 checks passed
@StevenMassaro StevenMassaro deleted the DAT-14921 branch March 21, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrackx abrackx abrackx approved these changes

@suryaaki2 suryaaki2 suryaaki2 approved these changes

@filipelautert filipelautert Awaiting requested review from filipelautert filipelautert is a code owner

Assignees
No one assigned
Labels
TypeBug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StevenMassaro @abrackx @suryaaki2