[DAT-16135] add new scope flag for modifyChangeSet flow #5707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwillard7800
approved these changes
Mar 18, 2024
KushnirykOleh
force-pushed
the
DAT-16135
branch
from
91e9199
to
8d3dd11
Compare
liquibase-standard/src/main/java/liquibase/changelog/DatabaseChangeLog.java
Outdated
Show resolved
Hide resolved
StevenMassaro
approved these changes
Mar 18, 2024
KushnirykOleh
changed the title
filipelautert
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
For some parsers, (like mongosh parsers) we need to know when modifyChangeSet flow is happening, as we can't run mongo instructions without native executor so
runWithis required. But in modifyChangeSet flowrunWithis added to the changeset later on, after parsing.Adding modifyChangeSets flag to the Scope allows parsers to read it and skip runWith validation knowing it's inner changeset and it gets 'runWith' attribute later.