Prevent error when unlocking the changelog in MySQL affects zero rows and useAffectedRows is true. Fixes #5502 #5777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and useAffectedRows is true
filipelautert
requested changes
Apr 8, 2024
liquibase-standard/src/main/java/liquibase/database/jvm/JdbcConnection.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
liquibase-standard/src/main/java/liquibase/database/jvm/JdbcConnection.java
Fixed
Show fixed
Hide fixed
filipelautert
approved these changes
Apr 9, 2024
liquibase-standard/src/main/java/liquibase/database/core/MySQLDatabase.java
Show resolved
Hide resolved
rberezen
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5502
Impact
Description
Whenever the JDBC driver for MySQL is configured with
useAffectedRowsand the changeset being processed has been processed before, the changelog unlocking mechanism returns zero rows affected and causes an error. This fix detects this situation and prevents an error from being raised.Things to be aware of
Only relevant for MySQL.
Things to worry about
Any other scenario that also causes the unlocking mechanism to return zero rows affected will be treated as a success. I am unaware of any scenarios breaking this change but maybe I'm overlooking something.
Additional Context